Skip to content

Task/g323 alias in secret lock #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from Oct 31, 2019
Merged

Task/g323 alias in secret lock #332

merged 2 commits into from Oct 31, 2019

Conversation

rg911
Copy link
Contributor

@rg911 rg911 commented Oct 30, 2019 •
edited
Loading

  • Fixed unsolvedMosaic and UnresolvedAddress in SecretLock and SecretProof transaction
  • Changed MetadataTransactionService return type

Issue: #323

@rg911 rg911 requested a review from fboucquez October 30, 2019 14:10
@coveralls
Copy link

coveralls commented Oct 30, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 808

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 807: 0.0%
Covered Lines: 10
Relevant Lines: 10
💛 - Coveralls

@rg911 rg911 merged commit 9578659 into symbol:master Oct 31, 2019
@fboucquez fboucquez deleted the task/g323_alias_in_secret_lock branch November 1, 2019 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@fboucquez fboucquez fboucquez approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rg911 @coveralls @fboucquez